Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add background for selected model #123

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

vincent0426
Copy link

@vincent0426 vincent0426 commented Nov 6, 2024

Description ✏️

Add background for selected model

Screenshot 2024-11-06 at 1 35 57 PM Screenshot 2024-11-06 at 1 36 03 PM

Checklist ✅

  • I have added screenshots (if UI changes are present).
  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).

@Fryingpannn
Copy link

nice I think color needs to look slightly different from when you hover over though

@vincent0426
Copy link
Author

Changed, also modify the text color for better contrast

theme: pearai light/dark

Screenshot 2024-11-06 at 6 14 16 PM Screenshot 2024-11-06 at 6 14 34 PM

@vincent0426 vincent0426 changed the title Feat: add background for selected background Feat: add background for selected model Nov 7, 2024
@Fryingpannn
Copy link

Shie the green might be too much LOL. I'd prefer the previous same color of this.

@vincent0426
Copy link
Author

@Fryingpannn how about, selected (lightGray55) vs not selected (lightGray33)

Screenshot 2024-11-09 at 2 31 31 PM Screenshot 2024-11-09 at 2 31 40 PM

Copy link

@cqdev-co cqdev-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, comes down to Pan's preference

@Himanshu-Singh-Chauhan Himanshu-Singh-Chauhan merged commit cc8dc49 into trypear:main Jan 27, 2025
nang-dev pushed a commit that referenced this pull request Feb 4, 2025
* Feat: add background for selected background

* Style: differentiate selected model text and bg color

* Style: change selected model bg color

* fixes

---------

Co-authored-by: Himanshu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants