Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added top-up card for non-subscribers #385

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Rihanmulani12
Copy link

@Rihanmulani12 Rihanmulani12 commented Nov 27, 2024

Description

Related Issue

Screenshots

top-up
top-up(1)

Checklist

  • I have tagged the issue in this PR.
  • I have attached necessary screenshots.
  • I have provided a short description of the PR.
  • I ran yarn build and build is successful
  • My code follows the style guidelines of this project.
  • I have added necessary documentation (if applicable)

Important

Add TopUpModalNonSubscriber component to display top-up options for non-subscribers in FreeTrialCard.

  • Feature:
    • Add TopUpModalNonSubscriber component in topup-nonsub.tsx to display top-up options for non-subscribers.
    • Integrate TopUpModalNonSubscriber into FreeTrialCard in freetrial-card.tsx.
  • UI:
    • Modal displays top-up packages with descriptions and prices.
    • Includes a "Don't show this again" option to hide the modal in future.
  • Misc:
    • Remove .env.local.example file.

This description was created by Ellipsis for 1d20c8a. It will automatically update as commits are pushed.

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pear-landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 7:39am

Copy link

vercel bot commented Nov 27, 2024

@Rihanmulani12 is attempting to deploy a commit to the PearAI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 1d20c8a in 1 minute and 22 seconds

More details
  • Looked at 219 lines of code in 3 files
  • Skipped 2 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. components/dashboard/topup-nonsub.tsx:76
  • Draft comment:
    Using localStorage to store the "hideTopUpModal" flag is not secure for sensitive data. Consider using a more secure storage method or a server-side solution if the data is sensitive or if the application is accessed on shared devices.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment addresses a potential security concern with using localStorage. However, the data being stored ('hideTopUpModal' flag) does not appear to be sensitive. The comment might be overly cautious given the context of the data being stored. The comment does not suggest a specific code change, which might make it less actionable.
    The comment might be valid in a general sense, but it doesn't seem to apply to the specific use case of storing a non-sensitive flag. The comment could be seen as speculative without strong evidence of an issue.
    While the comment raises a valid point about localStorage security, it doesn't seem directly applicable to the non-sensitive data being stored in this case. The comment lacks strong evidence of a necessary code change.
    The comment should be deleted as it does not provide strong evidence of a necessary code change for the specific use case of storing a non-sensitive flag in localStorage.
2. components/dashboard/topup-nonsub.tsx:23
  • Draft comment:
    Consider using the existing REQUEST_OPTIONS constant and extending it with descriptions if needed, rather than duplicating the pricing tier definitions.

  • constant REQUEST_OPTIONS (topup-modal.tsx)

  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is suggesting a refactor to avoid duplication, which is generally a good practice. However, the existing constant in the other file does not include descriptions, which are necessary for the current implementation. This means the suggestion is not directly applicable without additional changes.
    The comment assumes that the existing constant can be used as-is, but it lacks the descriptions needed for the current file. This makes the suggestion less straightforward than it appears.
    While the suggestion to avoid duplication is valid, the lack of descriptions in the existing constant means the comment is not directly actionable without further modification.
    The comment should be deleted because the existing constant does not include descriptions, making the suggestion not directly applicable.

Workflow ID: wflow_8RybFkvg39yMGyim


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

components/dashboard/topup-nonsub.tsx Outdated Show resolved Hide resolved
@Rihanmulani12
Copy link
Author

@Fryingpannn any feedback ?

@Fryingpannn
Copy link
Contributor

should not delete yarn lock or env example

also no need new file for this. simply in existing top up, check if user is sub, then display different text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants