Fix cronos #102
Merged
Fix cronos #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCell
reviewed
Jun 29, 2023
| if err != nil { | ||
| return fmt.Errorf("failed to get chain from asset type: %w", err) | ||
| } | ||
|
|
||
| chainFromType := chainFromTypeRaw | ||
| if chainFromTypeRaw.ID == coin.CRONOS { | ||
| chainFromType = coin.Cryptoorg() |
There was a problem hiding this comment.
can we update this information on assets repo?
There was a problem hiding this comment.
unfortunately we can't without copypasting whole validate func from here
There was a problem hiding this comment.
wait, I haven't approved this PR.
I saw this PR https://github.com/trustwallet/assets/pull/25575/files is fixing the wrong directory, so why do we still need this change?
There was a problem hiding this comment.
In check CI action we had 2 type of errors:
- Invalid explorer url. It was fixed by https://github.com/trustwallet/assets/pull/25575/files
- When trying to get corresponding chain to CRC20 token, it returns Cronos which causes other type of validation error. It was fixed by this line
There was a problem hiding this comment.
Got it, thank you.
May I ask you to add comments above your changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trustwallet/assets#25572