Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

fix: rewrite bundled extensions to mjs for esm build #86

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

sachinraja
Copy link
Member

The current index.mjs re-exports from the CJS .js files instead of the ESM .mjs files: https://unpkg.com/browse/[email protected]/lib/index.mjs. I guess tsup does not rewrite the extensions. This PR adds an esbuild plugin to rewrite the extensions for the ESM build.

Copy link

vercel bot commented Nov 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tupleson-async ✅ Ready (Inspect) Visit Preview Nov 4, 2023 6:10pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #86 (98094a5) into main (4cf7fef) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files          31       31           
  Lines        1876     1876           
  Branches      194      194           
=======================================
  Hits         1765     1765           
  Misses        109      109           
  Partials        2        2           
Flag Coverage Δ
unit 94.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KATT KATT merged commit 9bf904f into main Nov 8, 2023
15 checks passed
@KATT KATT deleted the fix-bundling branch November 8, 2023 01:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants