Enable startAdvertising with both a region and a list of UUIDs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am surprised this works. The advertisement packet is not that large. Can an iBeacon and services both be advertised? Could you also write a simple test app, based on the PeripheralManager app, that advertises an iBeacon and services. Place it in the examples directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi BlueCapKit maintainer,
The peripheralManager has two versions of the startAdvertising function, one takes in a beacon region as an argument and the other one takes a list of UUIDs to advertise as an argument. This MR adds a version of startAdvertising that takes in both arguments, as well as the peripheral name. We found the more generic case to give us better flexibility. We also wrote unit tests make sure the expected behavior happens either when self.isAdvertising is on or off. We would like to merge that to upstream as soon as possible.