fstab with UUID/LABEL: nofail handling for fsck #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troglobit
requested changes
Dec 18, 2024
|
On Wed, 18 Dec 2024 00:53:58 -0800, Joachim Wiberg writes:
Nice catch, and thank you for the PR! Only a small mistake in the patch.
ooops, sorry about that. patch patched...*sigh*
…--
Alexander Zangerl + GPG Key 2FCCF66BB963BD5F + https://snafu.priv.at/
"Opinions are like assholes, I'll let you know when I want yours."
-- David Cross and/or Bob Odenkirk
|
No worries, happens to the best of us 😃 Please rebase, squash, and force-push your branch. |
add support for 'nofail' fstab option. if present, finit's fsck invocation ignores errors for this device. this is useful if you have an fstab entry for a device with UUID= or LABEL= which isn't always present and which you'd like to not bail on (so you set nofail). in this case finit leaves the presence-or-not decision to fsck, which exits nonzero. for block devices that are directly listed in fstab this change isn't important, because for such finit looks for the blockdev's existence and skips the fsck if n/a.
|
squashed and pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #421: add support for 'nofail' fstab option. if present, finit's fsck invocation ignores errors for this device.
this is useful if you have an fstab entry for a device with UUID= or LABEL= which isn't always present and which you'd like to not bail on (so you set nofail). in this case finit leaves the presence-or-not decision to fsck, which exits nonzero.
for block devices that are directly listed in fstab this change isn't important, because for such finit looks for the blockdev's existence and skips the fsck if n/a.