-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update comments for some DGSEM
APIs
#2238
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Trixi.jl/src/solvers/dgsem/dgsem.jl Lines 54 to 57 in 9893b73
I guess this is also deprecated. Should I add a comment for it or just remove it? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2238 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 487 487
Lines 39355 39355
=======================================
Hits 37945 37945
Misses 1410 1410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
A comment would be good. Since it is part of the API, we cannot just remove it without creating a breaking release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
The original comments for these deprecated
DGSEM
are quite confusing.