Build Updates for Ubuntu24.04 #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error -
```
/tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:413:58: error: redefinition of default argument for 'typename std::enable_if<(! std::is_same<typename std::iterator_traits< <template-parameter-1-1> >::value_type, std::__cxx11::basic_string<char> >::value)>::type* <anonymous>'
413 | std::string>::value>::type* = nullptr>
| ^~~~~~~
/tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:316:41: note: original definition appeared here
316 | std::string>::value>::type* = nullptr>
| ^~~~~~~
make[2]: *** [CMakeFiles/triton-developer_tools-server.dir/build.make:76: CMakeFiles/triton-developer_tools-server.dir/src/server_wrapper.cc.o] Error 1
```
This reverts commit 9f8ea3d.
mc-nv
reviewed
Nov 1, 2024
| @@ -410,7 +410,7 @@ InferRequest::AddInput( | |||
| template < | |||
| typename Iterator, typename std::enable_if<!std::is_same< | |||
| typename std::iterator_traits<Iterator>::value_type, | |||
| std::string>::value>::type* = nullptr> | |||
| std::string>::value>::type*> | |||
There was a problem hiding this comment.
Could you please clarify why default value to the pointer changed?
There was a problem hiding this comment.
yeah, there was an error due to default arg being redefined in declaration
/opt/tritonserver/developer_tools/server/include/triton/developer_tools/server_wrapper.h:384:58: error: redefinition of default argument for 'typename std::enable_if<std::is_same<typename std::iterator_traits< <template-parameter-1-1> >::value_type, std::__cxx11::basic_string<char> >::value>::type* <anonymous>'
384 | std::string>::value>::type* = nullptr>
| ^~~~~~~
/opt/tritonserver/developer_tools/server/include/triton/developer_tools/server_wrapper.h:293:41: note: original definition appeared here
293 | std::string>::value>::type* = nullptr>
| ^~~~~~~
/opt/tritonserver/developer_tools/server/include/triton/developer_tools/server_wrapper.h:413:58: error: redefinition of default argument for 'typename std::enable_if<(! std::is_same<typename std::iterator_traits< <template-parameter-1-1> >::value_type, std::__cxx11::basic_string<char> >::value)>::type* <anonymous>'
413 | std::string>::value>::type* = nullptr>
| ^~~~~~~
/opt/tritonserver/developer_tools/server/include/triton/developer_tools/server_wrapper.h:316:41: note: original definition appeared here
316 | std::string>::value>::type* = nullptr>
|
There was a problem hiding this comment.
I see that default arg was given to iterator, it means that it expect that that value will be nullptr by default.
As I see there is an * symbol which may correspond to the pointer. Pointer in C++ must be initialized.
mc-nv
added a commit
that referenced
this pull request
Nov 12, 2024
* Build Updates for Ubuntu24.04 (#50) * update cmake version for u24 * temp: override client repo tag * remove werror * fix0 - redefinition error Error - ``` /tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:413:58: error: redefinition of default argument for 'typename std::enable_if<(! std::is_same<typename std::iterator_traits< <template-parameter-1-1> >::value_type, std::__cxx11::basic_string<char> >::value)>::type* <anonymous>' 413 | std::string>::value>::type* = nullptr> | ^~~~~~~ /tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:316:41: note: original definition appeared here 316 | std::string>::value>::type* = nullptr> | ^~~~~~~ make[2]: *** [CMakeFiles/triton-developer_tools-server.dir/build.make:76: CMakeFiles/triton-developer_tools-server.dir/src/server_wrapper.cc.o] Error 1 ``` * fix1 - redefinition error * Revert "temp: override client repo tag" This reverts commit 9f8ea3d. * Update server/install_dependencies_and_build.sh --------- Co-authored-by: Anant Sharma <[email protected]>
mc-nv
added a commit
that referenced
this pull request
Nov 22, 2024
* Build Updates for Ubuntu24.04 (#50) * update cmake version for u24 * temp: override client repo tag * remove werror * fix0 - redefinition error Error - ``` /tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:413:58: error: redefinition of default argument for 'typename std::enable_if<(! std::is_same<typename std::iterator_traits< <template-parameter-1-1> >::value_type, std::__cxx11::basic_string<char> >::value)>::type* <anonymous>' 413 | std::string>::value>::type* = nullptr> | ^~~~~~~ /tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:316:41: note: original definition appeared here 316 | std::string>::value>::type* = nullptr> | ^~~~~~~ make[2]: *** [CMakeFiles/triton-developer_tools-server.dir/build.make:76: CMakeFiles/triton-developer_tools-server.dir/src/server_wrapper.cc.o] Error 1 ``` * fix1 - redefinition error * Revert "temp: override client repo tag" This reverts commit 9f8ea3d. * Update server/install_dependencies_and_build.sh --------- Co-authored-by: Anant Sharma <[email protected]>
mc-nv
added a commit
that referenced
this pull request
Nov 26, 2024
* Build Updates for Ubuntu24.04 (#50) * update cmake version for u24 * temp: override client repo tag * remove werror * fix0 - redefinition error Error - ``` /tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:413:58: error: redefinition of default argument for 'typename std::enable_if<(! std::is_same<typename std::iterator_traits< <template-parameter-1-1> >::value_type, std::__cxx11::basic_string<char> >::value)>::type* <anonymous>' 413 | std::string>::value>::type* = nullptr> | ^~~~~~~ /tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:316:41: note: original definition appeared here 316 | std::string>::value>::type* = nullptr> | ^~~~~~~ make[2]: *** [CMakeFiles/triton-developer_tools-server.dir/build.make:76: CMakeFiles/triton-developer_tools-server.dir/src/server_wrapper.cc.o] Error 1 ``` * fix1 - redefinition error * Revert "temp: override client repo tag" This reverts commit 9f8ea3d. * Update server/install_dependencies_and_build.sh --------- Co-authored-by: Anant Sharma <[email protected]>
pvijayakrish
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Build Updates for Ubuntu24.04 (#50) * update cmake version for u24 * temp: override client repo tag * remove werror * fix0 - redefinition error Error - ``` /tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:413:58: error: redefinition of default argument for 'typename std::enable_if<(! std::is_same<typename std::iterator_traits< <template-parameter-1-1> >::value_type, std::__cxx11::basic_string<char> >::value)>::type* <anonymous>' 413 | std::string>::value>::type* = nullptr> | ^~~~~~~ /tmp/build/javacpp-presets/tritonserver/cppbuild/tritonbuild/developer_tools/server/include/triton/developer_tools/server_wrapper.h:316:41: note: original definition appeared here 316 | std::string>::value>::type* = nullptr> | ^~~~~~~ make[2]: *** [CMakeFiles/triton-developer_tools-server.dir/build.make:76: CMakeFiles/triton-developer_tools-server.dir/src/server_wrapper.cc.o] Error 1 ``` * fix1 - redefinition error * Revert "temp: override client repo tag" This reverts commit 9f8ea3d. * Update server/install_dependencies_and_build.sh --------- Co-authored-by: Anant Sharma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.