Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update to default triton repositories in README #48

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

mattwittwer
Copy link
Contributor

What does the PR do?

Update the default triton repositories used in this build to reflect those used: https://github.com/triton-inference-server/developer_tools/blob/main/server/CMakeLists.txt#L60

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Can start by verifying the triton repositories pulled here: https://github.com/triton-inference-server/developer_tools/blob/main/server/CMakeLists.txt#L60 and confirm these match with the updated README field.

Test plan:

  • CI Pipeline ID:

Caveats:

Background

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@mattwittwer mattwittwer added the documentation Improvements or additions to documentation label Jul 31, 2024
@mattwittwer mattwittwer requested a review from indrajit96 July 31, 2024 18:20
@mattwittwer mattwittwer self-assigned this Jul 31, 2024
Copy link

@indrajit96 indrajit96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Can ignore pipeline as README.md change

@mattwittwer mattwittwer merged commit 4c250f6 into main Aug 5, 2024
1 of 3 checks passed
@mattwittwer mattwittwer deleted the mwittwer-update-server-readme branch August 5, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants