Make some form elements optional for blast database setup #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2024
laceysanderson
added
Group 2 - User Interface
laceysanderson
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Tested locally and this works exactly as expected. Thanks @shreyas-a-s ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description updated based on issue
Issue #111
This PR makes a number of new settings focused on linkouts optional in the blast database entity form. These settings are not yet well described and thus not clear how to fill out. We will evaluate whether they need to be required at a later date once this module is more stable.
Testing
Create a blast database through the UI and confirm you can leave these fields empty and the page is created without error.