-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Feature/tibero connector #27854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/tibero connector #27854
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: hmc7491871.
|
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
chenjian2664
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the connector tests?
| case Types.SMALLINT: | ||
| return Optional.of(smallintColumnMapping()); | ||
|
|
||
| case Types.INTEGER: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add type mapping tests, you can refer TestPostgreSqlTypeMapping
| 1. Obtain the Tibero JDBC driver (tibero7-jdbc.jar) from TmaxSoft. | ||
| 2. Copy the driver to the Trino plugin directory: | ||
| ``` | ||
| cp tibero7-jdbc.jar $TRINO_HOME/plugin/tibero/ | ||
| ``` | ||
| 3. Restart the Trino server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the jdbc allows using in open source project, what's the license it allows?
| @@ -0,0 +1,294 @@ | |||
| # Tibero connector | |||
|
|
|||
| The Tibero connector allows querying and creating tables in an external Tibero | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a link to the database's official homepage? I’m not familiar with it, and having a reference link would help readers understand it better
…and type mapping tests
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@chenjian2664
Please review and let me know if any further adjustments are needed. |
90fc42e to
83d0233
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
83d0233 to
a367b8f
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Description
This PR adds a new JDBC connector for Tibero database. Tibero is an enterprise-grade relational database management system that is Oracle-compatible and widely used in enterprise environments.
The connector extends
BaseJdbcClientand provides:Additional context and related issues
The implementation follows the same pattern as other JDBC connectors in Trino (e.g., Oracle, PostgreSQL). The connector handles Tibero's type system including:
Note: The connector uses a system-scoped JDBC driver dependency which needs to be configured with the actual Tibero JDBC driver location.
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: