Handle edge cases when converting double from JSON to Trino types #24030
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Currently, we are unable to optimise tables when they contain infinity/NaN values in fields of type "DOUBLE" because the conversion fails when we try to cast a string containing "Infinity", "-Infinity" or "NaN" into a double. Instead, we try to check if the JSON value contains a string, and convert it appropriately.
Pluies
force-pushed
the
delta-checkpoint-support-infinity
branch
from
11f405a
to
bf16c90
Compare
|
Tagging @ebyhr as the original author and @findepi as the original commentor of this prescient review comment 😄 |
|
Note that this is mostly a first draft for inputs & review, we'll need to add tests, but I wanted to first check that you agree with the approach and check if you had a better way to do it. |
|
@Pluies This approach looks good to me. Could you please start adding tests? |
findepi
reviewed
Nov 5, 2024
Comment on lines
+130
to
+131
| if (jsonValue instanceof String) { | ||
| switch ((String) jsonValue) { |
There was a problem hiding this comment.
Suggested change
| if (jsonValue instanceof String) { | |
| switch ((String) jsonValue) { | |
| if (jsonValue instanceof String stringValue) { | |
| switch (stringValue) { |
| case "-Infinity" -> { | ||
| return Double.NEGATIVE_INFINITY; | ||
| } | ||
| case "NaN" -> { |
| @@ -127,6 +127,20 @@ public static Object jsonValueToTrinoValue(Type type, @Nullable Object jsonValue | |||
| return (long) floatToRawIntBits((float) (double) jsonValue); | |||
| } | |||
| if (type == DOUBLE) { | |||
| if (jsonValue instanceof String) { | |||
| switch ((String) jsonValue) { | |||
| case "Infinity" -> { | |||
There was a problem hiding this comment.
can it be inf (besides case differences)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we are unable to optimise tables when they contain infinity/NaN values in fields of type "DOUBLE" because the conversion fails when we try to cast a string containing "Infinity", "-Infinity" or "NaN" into a double.
Instead, we try to check if the JSON value contains a string, and convert it appropriately.
Additional context and related issues
Fixes #24029
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: