Support limit pushdown in Bigquery connector #24021
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krvikash
changed the title
krvikash
force-pushed
the
bigquery-limit-pushdown
branch
from
9bf5459
to
e3d5b41
Compare
krvikash
force-pushed
the
bigquery-limit-pushdown
branch
from
e3d5b41
to
2061c56
Compare
krvikash
changed the title
krvikash
requested review from
ssheikin,
ebyhr,
Praveen2112,
vlad-lyutenko,
pajaks and
marcinsbd
|
/test-with-secrets sha=2061c56273afc55ffabb8bb4e139e3260bf7488b |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/11694897950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #23937
Since BigQuery Storage API doesn't support limiting rows, but REST API supports LIMIT clause.
https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#limit_and_offset_clause
So, We will be using REST API to read all kinds of table (view, MV, managed table, external table, snapshot table, ...) when limit is specified in the query.
Release notes