Make Faker deterministic #24008
Merged
Make Faker deterministic #24008
+58
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
reviewed
Nov 4, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerPageSourceProvider.java
Outdated
Show resolved
Hide resolved
wendigo
reviewed
Nov 4, 2024
plugin/trino-faker/src/test/java/io/trino/plugin/faker/FakerQueryRunner.java
Outdated
Show resolved
Hide resolved
wendigo
approved these changes
Nov 4, 2024
When limit was set to a multiplication of MAX_ROWS_PER_SPLIT (250 * 4096), last split contained a limit of zero, instead of MAX_ROWS_PER_SPLIT.
nineinchnick
force-pushed
the
faker-seed
branch
2 times, most recently
from
7eb9bcf
to
0d2fbf2
Compare
Pluies
reviewed
Nov 4, 2024
plugin/trino-faker/src/main/java/io/trino/plugin/faker/FakerPageSourceProvider.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Nov 5, 2024
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
nineinchnick
force-pushed
the
faker-seed
branch
from
0d2fbf2
to
3fc2da2
Compare
ebyhr
reviewed
Nov 5, 2024
plugin/trino-faker/src/test/java/io/trino/plugin/faker/TestFakerQueries.java
Outdated
Show resolved
Hide resolved
ebyhr
approved these changes
Nov 5, 2024
nineinchnick
force-pushed
the
faker-seed
branch
from
3fc2da2
to
a1aaaa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a jumpable random generator and make sure to jump it a different number of times for every split.
Ref: https://docs.oracle.com/en/java/javase/23/core/choosing-prng-algorithm.html
Release notes