Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Iceberg from 0.14.1 to 1.0.0 #14678

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Oct 19, 2022

Description

This updates the trino-iceberg connector to the latest Iceberg version 1.0.0. This release is based on the 0.14.1 release and includes changes to remove deprecated APIs with some bug fixes. Release notes can be found here.

@cla-bot cla-bot bot added the cla-signed label Oct 19, 2022
@nastra nastra closed this Oct 19, 2022
@nastra nastra reopened this Oct 19, 2022
@nastra nastra closed this Oct 19, 2022
@nastra nastra reopened this Oct 19, 2022
@nastra nastra requested a review from ebyhr October 19, 2022 08:53
@nastra nastra closed this Oct 19, 2022
@nastra nastra reopened this Oct 19, 2022
@nastra nastra closed this Oct 19, 2022
@nastra nastra reopened this Oct 19, 2022
@nastra
Copy link
Contributor Author

nastra commented Oct 20, 2022

is this a known failure (see also JodaOrg/joda-time#524 (comment))?

2022-10-20T06:06:16.6986966Z 2022-10-20T01:06:16.696-0500	ERROR	pool-53-thread-2	io.trino.testng.services.ProgressLoggingListener	[TEST FAILURE] io.trino.util.TestTimeZoneUtils.testNamedZones; (took: 0.0 seconds)
2022-10-20T06:06:16.6988458Z java.lang.IllegalArgumentException: The datetime zone id 'Europe/Kyiv' is not recognised
2022-10-20T06:06:16.6989106Z 	at org.joda.time.DateTimeZone.forID(DateTimeZone.java:247)
2022-10-20T06:06:16.6989906Z 	at io.trino.util.TestTimeZoneUtils.testNamedZones(TestTimeZoneUtils.java:46)
2022-10-20T06:06:16.6990610Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2022-10-20T06:06:16.6991367Z 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
2022-10-20T06:06:16.6992201Z 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2022-10-20T06:06:16.6992897Z 	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
2022-10-20T06:06:16.6993764Z 	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
2022-10-20T06:06:16.6994467Z 	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
2022-10-20T06:06:16.6995230Z 	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
2022-10-20T06:06:16.6996027Z 	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
2022-10-20T06:06:16.6996722Z 	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
2022-10-20T06:06:16.6997444Z 	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
2022-10-20T06:06:16.6998166Z 	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
2022-10-20T06:06:16.6998916Z 	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
2022-10-20T06:06:16.6999682Z 	at java.base/java.lang.Thread.run(Thread.java:833)
2022-10-20T06:06:16.7000193Z 

@ebyhr
Copy link
Member

ebyhr commented Oct 20, 2022

The test is already fixed in #14684

This updates the `trino-iceberg` connector to the latest Iceberg version 1.0.0. This release is based on the 0.14.1 release and includes changes to remove deprecated APIs with some bug fixes. Release notes can be found [here](https://iceberg.apache.org/releases/#100-release).
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Oct 20, 2022
@findepi findepi merged commit 4eb0c5f into trinodb:master Oct 20, 2022
@github-actions github-actions bot added this to the 401 milestone Oct 20, 2022
@nastra nastra deleted the iceberg-1.0 branch October 20, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants