Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for LIMIT pushdown in BigQuery connector #23937

Open
ebyhr opened this issue Oct 28, 2024 · 3 comments · May be fixed by #24021
Open

Add support for LIMIT pushdown in BigQuery connector #23937

ebyhr opened this issue Oct 28, 2024 · 3 comments · May be fixed by #24021
Assignees
@krvikash
Labels
bigquery BigQuery connector

Comments

@ebyhr
Copy link
Member

ebyhr commented Oct 28, 2024

BigQuery Storage API doesn't support limiting rows, but REST API supports LIMIT clause.
https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#limit_and_offset_clause
@ebyhr ebyhr added the bigquery BigQuery connector label Oct 28, 2024
@ebyhr
Copy link
Member Author

ebyhr commented Oct 28, 2024

cc: @pajaks

@chenjian2664
Copy link
Contributor

Would like to take this if you haven't start on this @pajaks Please let me know, thanks

@pajaks
Copy link
Member

pajaks commented Oct 30, 2024

Would like to take this if you haven't start on this @pajaks Please let me know, thanks

@chenjian2664 Fell free to take it

@chenjian2664 chenjian2664 self-assigned this Oct 31, 2024
@ebyhr ebyhr linked a pull request Nov 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krvikash krvikash

Labels
bigquery BigQuery connector
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support limit pushdown in Bigquery connector krvikash/trino
4 participants
@ebyhr @krvikash @chenjian2664 @pajaks