Add sorting for clusters and query history page columns #752
Conversation
|
CI build seemed to have failed with an unrelated error - |
|
Could you add screenshots to PR description when you modify UI code? |
Sure, done |
| return a.routingGroup.localeCompare(b.routingGroup); | ||
| }} | ||
| filters={ | ||
| [...new Set(backendData?.map(b => b.routingGroup))] |
There was a problem hiding this comment.
if backendData is undefined this may become new Set([undefined]), perhaps default to empty array
There was a problem hiding this comment.
if backendData is undefined, it will be new Set(undefined) which will give an empty set. So filters array will be simply empty array so i think it is ok like this.
| return a.routingGroup.localeCompare(b.routingGroup); | ||
| }} | ||
| filters={ | ||
| [...new Set(backendData?.map(b => b.routingGroup))] |
There was a problem hiding this comment.
if backendData is undefined, it will be new Set(undefined) which will give an empty set. So filters array will be simply empty array so i think it is ok like this.
| @@ -19,3 +19,6 @@ ij_java_doc_align_param_comments = false | |||
|
|
|||
| [*.yml] | |||
| indent_size = 2 | |||
|
|
|||
| [*.tsx] | |||
| indent_size = 2 | |||
There was a problem hiding this comment.
Please separate a commit. This change is unrelated to "Add sorting for clusters and query history page columns".
Description
Added sort options for clusters based on name, queued query count and running query count.
Added filter option for routingGroup and sort options for routignGroup and submission time in query history page.
Additional context and related issues
Clusters page header [3 new sort icons on Name, Queued, Running]:
History Page [Sort and Filter option on RoutingGroup] -
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( X) Release notes are required, with the following suggested text: