Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation notifications since SF 5.1 #287

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ricohumme
Copy link

symfony/dependency-injection states deprecated tags in configurations should have the package name and the version the deprecation started.
This PR will fix that issue

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.43%. Comparing base (09462b1) to head (d702614).
Report is 14 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #287      +/-   ##
============================================
- Coverage     92.54%   92.43%   -0.11%     
  Complexity      438      438              
============================================
  Files            65       61       -4     
  Lines          1555     1521      -34     
============================================
- Hits           1439     1406      -33     
+ Misses          116      115       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ricohumme
Copy link
Author

@X-Coder264 fyi these test failures are not due to my contribution.
Could this be merged as the impact is low code-wise, but highly on the deprecation logs in the application for users working with SF 5.1+
Thank you in advance!

@X-Coder264
Copy link
Collaborator

@ricohumme Some builds fail due to some message changes which were recently made in league/oauth2-server package. But some builds fail due to this change as IIRC this change is not compatible with Symfony 4.4 and 5.0 which we still support on the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants