Skip to content

Conversation

@chrisblossom
Copy link
Contributor

Because node_modules are not consistent I found some issues where my snapshots were failing. This makes all node_modules under a single <NODE_MODULES> tag.

@chrisblossom chrisblossom changed the title replace node_modules with NODE_MODULES replace node_modules with <NODE_MODULES> May 15, 2018
@coveralls
Copy link

coveralls commented May 15, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 68d49b6 on chrisblossom:handle-node-modules into 6ab7111 on tribou:master.

@chrisblossom
Copy link
Contributor Author

chrisblossom commented May 16, 2018

I'm not 100% sure this should be merged because it might have other side effects. Wonder if there is a way we can make this opt-in?

Edit: Definitely hold off on merging this. It will break any text with node_modules and I think a better solution will need to be thought out completely / this might need to be dropped entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants