feat(suite): Delete mobile menu #16336
Open
+61
−300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvaclavik
force-pushed
the
delete-mobile-menu
branch
from
3307d88 to
9b1e004
Compare
jvaclavik
force-pushed
the
delete-mobile-menu
branch
from
9b1e004 to
fc4b335
Compare
tomasklim
reviewed
Jan 14, 2025
packages/suite/src/components/suite/layouts/SuiteLayout/SuiteLayout.tsx
Outdated
Show resolved
Hide resolved
jvaclavik
force-pushed
the
delete-mobile-menu
branch
from
fc4b335 to
bceac79
Compare
adamhavel
requested changes
Jan 15, 2025
| sidebarWidthFromRedux: number; | ||
| }) => { | ||
| const [sidebarWidth, setSidebarWidth] = useState<number>(sidebarWidthFromRedux); | ||
| const [contentWidth, setContentWidth] = useState<number | undefined>(undefined); | ||
|
|
||
| const getIsSidebarCollapsed = () => { |
There was a problem hiding this comment.
Isn't isSidebarCollapsed enough?
| import { useSelector } from 'src/hooks/suite'; | ||
|
|
||
| import { useResponsiveContext } from '../../support/suite/ResponsiveContext'; | ||
|
|
||
| const Container = styled.div` |
There was a problem hiding this comment.
This can be redone with Box, including the media query part, and Divider.
| margin-right: -${spacingsPx.md}; | ||
| padding-left: ${spacingsPx.md}; | ||
| padding-right: ${spacingsPx.md}; | ||
| width: calc(100% + ${spacingsPx.xxl}); |
There was a problem hiding this comment.
This is not needed, just set it to auto, I think.
| @@ -56,7 +58,7 @@ const MobilePromoContainer = styled.div` | |||
| ${promoContainerCss} | |||
| justify-content: start; | |||
|
|
|||
| ${variables.SCREEN_QUERY.MOBILE} { | |||
| ${variables.SCREEN_QUERY.BELOW_LAPTOP} { | |||
There was a problem hiding this comment.
Custom css components not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Resolve #15801
Screenshots: