Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connnect): solanaComposeTransaction method #16208

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Conversation

martykan
Copy link
Member

@martykan martykan commented Jan 6, 2025

Description

Moved solanaUtils from wallet-utils to connect package.
Wrapped the API into a new method solanaComposeTransaction.
Improved solanaSignTransaction for better interoperability with this method.
Applied these changes to Suite send form Solana thunk.

Related Issue

Resolve #10907

QA

Please closely test Solana send flows

Copy link

github-actions bot commented Jan 6, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 21
  • More info

Learn more about 𝝠 Expo Github Action

@martykan martykan force-pushed the chore/solana-to-connect branch 4 times, most recently from 43bf378 to e808d0d Compare January 8, 2025 15:38
@martykan martykan changed the title wip: solanaUtils to connect feat(connnect): solanaComposeTransaction method Jan 8, 2025
@martykan martykan force-pushed the chore/solana-to-connect branch 2 times, most recently from 37653e8 to 7e6c0a5 Compare January 13, 2025 12:24
@martykan martykan added connect Connect API related (ie. fee calculation) solana labels Jan 13, 2025
@martykan martykan marked this pull request as ready for review January 13, 2025 12:46
@mroz22
Copy link
Contributor

mroz22 commented Jan 13, 2025

i can sense conflicts with #16286

@martykan
Copy link
Member Author

martykan commented Jan 13, 2025

Yeah, this definitely seems redundant to #16286. I can drop 0fcc348 from here.

Edit: dropped now

@martykan martykan force-pushed the chore/solana-to-connect branch from 7e6c0a5 to c074fc5 Compare January 13, 2025 14:46
@martykan martykan force-pushed the chore/solana-to-connect branch from 74c038f to 0294772 Compare January 14, 2025 10:12
@mroz22 mroz22 merged commit 0c02e51 into develop Jan 14, 2025
79 checks passed
@mroz22 mroz22 deleted the chore/solana-to-connect branch January 14, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connect Connect API related (ie. fee calculation) solana
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Solana deps from Suite to Connect
2 participants