-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connnect): solanaComposeTransaction method #16208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Expo preview is ready!
|
martykan
force-pushed
the
chore/solana-to-connect
branch
4 times, most recently
from
January 8, 2025 15:38
43bf378
to
e808d0d
Compare
martykan
changed the title
wip: solanaUtils to connect
feat(connnect): solanaComposeTransaction method
Jan 8, 2025
martykan
force-pushed
the
chore/solana-to-connect
branch
2 times, most recently
from
January 13, 2025 12:24
37653e8
to
7e6c0a5
Compare
martykan
requested review from
mroz22,
szymonlesisz,
marekrjpolak and
Nodonisko
as code owners
January 13, 2025 12:46
mroz22
reviewed
Jan 13, 2025
i can sense conflicts with #16286 |
martykan
force-pushed
the
chore/solana-to-connect
branch
from
January 13, 2025 14:46
7e6c0a5
to
c074fc5
Compare
mroz22
approved these changes
Jan 14, 2025
martykan
force-pushed
the
chore/solana-to-connect
branch
from
January 14, 2025 10:12
74c038f
to
0294772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved
solanaUtils
fromwallet-utils
toconnect
package.Wrapped the API into a new method
solanaComposeTransaction
.Improved
solanaSignTransaction
for better interoperability with this method.Applied these changes to Suite send form Solana thunk.
Related Issue
Resolve #10907
QA
Please closely test Solana send flows