Skip to content

Conversation

@PeterStolz
Copy link
Contributor

@PeterStolz PeterStolz commented Dec 12, 2025

…t.toml migration

Change Description

Background

The docs reference this broken snippet:

pip install lakefs
python -m lakefs.quickstart

It is broken because someone migrated to pyproject.toml 2 months ago and was not aware that the subfolders quickstart and download are not recursively included. This leads to the documentation breaking.

Bug Fix

If this PR is a bug fix, please let us know about:

  1. Problem - subfolders are not included in the wheels
  2. Root cause - migration to pyproject.toml was not tested properly
  3. Solution - by adding the wildcard, python files in subfolders are included again

Testing Details

How were the changes tested?
in the folder lakeFS/clients/python-wrapper run

pip install --upgrade .
cd .. # important as otherwise python uses the local folder and not the installed package
python -c "import lakefs.quickstart, lakefs.download; print('ok')" # will cause a ModuleNotFoundError: No module named 'lakefs.quickstart'

When you run it on my commit it correctly prints ok and you can also run python -m lakefs.quickstart again

Breaking Change?

Does this change break any existing functionality?
No it restores them

Contact Details

How can we get in touch with you if we need more info? (ex. [email protected])

Close #9788

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file area/sdk/python labels Dec 12, 2025
@nopcoder nopcoder self-requested a review December 12, 2025 10:49
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! minor comment

@PeterStolz
Copy link
Contributor Author

I applied your suggestion and verified that it works 👍

@PeterStolz PeterStolz requested a review from nopcoder December 12, 2025 15:02
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nopcoder nopcoder added the include-changelog PR description should be included in next release changelog label Dec 12, 2025
@nopcoder nopcoder merged commit 9016dbf into treeverse:master Dec 13, 2025
80 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sdk/python dependencies Pull requests that update a dependency file include-changelog PR description should be included in next release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix missing lakefs.quickstart and lakefs.download after pyproject.toml migration

3 participants