Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated and renamed spark-client.md to spark-metadata-client.md #8042

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimmymcnutty
Copy link
Contributor

Closes #(Insert issue number closed by this PR)

Change Description

Background

Share context and relevant information for the PR: offline discussions, considerations, design decisions etc.

Bug Fix

If this PR is a bug fix, please let us know about:

  1. Problem - The reason for opening the bug
  2. Root cause - Discovered root cause after investigation
  3. Solution - How the bug was fixed

New Feature

If this PR introduces a new feature, describe it here.

Testing Details

How were the changes tested?

Breaking Change?

Does this change break any existing functionality? (API, CLI, Clients)

Additional info

Logs, outputs, screenshots of changes if applicable (CLI / GUI changes)

Contact Details

How can we get in touch with you if we need more info? (ex. [email protected])

Copy link

github-actions bot commented Aug 2, 2024

E2E Test Results - Quickstart

10 passed

Copy link

github-actions bot commented Aug 2, 2024

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed

Copy link
Collaborator

@ozkatz ozkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

title: Spark Client
description: The lakeFS Spark client performs operations on lakeFS committed metadata stored in the object store.
title: Spark Metadata Client
description: The lakeFS Spark client performs operations on lakeFS committed Metadata stored in the object store.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why captitalize it everywhere?

@N-o-Z
Copy link
Member

N-o-Z commented Oct 23, 2024

@jimmymcnutty hey - we should either fix the comments and merge or close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants