Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bindings for 0.24 #259

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Update bindings for 0.24 #259

merged 2 commits into from
Oct 15, 2024

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Oct 15, 2024

Namely:

  • CMake support
  • restructure some bindings
  • migrate to tree-sitter.json

tree-sitter.json Outdated Show resolved Hide resolved
@amaanq amaanq force-pushed the update branch 2 times, most recently from 0fa49a2 to cd9d157 Compare October 15, 2024 05:25
@amaanq
Copy link
Member Author

amaanq commented Oct 15, 2024

I'll leave it to you to fix the failing file @calebdw :)

@amaanq amaanq merged commit 69af07e into master Oct 15, 2024
1 of 4 checks passed
@calebdw
Copy link
Collaborator

calebdw commented Oct 15, 2024

I'll leave it to you to fix the failing file

Issue is that unary op expressions (-1) aren't supported in enums yet, I'll send a fix.

By the way, would it be possible to update the parse action to show any failed files up front? It's kind of a pain to have to scroll through miles of lines to see which one failed

https://github.com/tree-sitter/tree-sitter-php/actions/runs/11339991148/job/31535650336

@calebdw
Copy link
Collaborator

calebdw commented Oct 15, 2024

Ah 🤣 that would've helped.

@tree-sitter tree-sitter deleted a comment from amaanq Oct 15, 2024
@calebdw calebdw deleted the update branch October 15, 2024 13:59
@calebdw
Copy link
Collaborator

calebdw commented Oct 15, 2024

Do we no longer run the local tests in ci? It looks like we just parse example files

(Sorry for deleting your comment---it came through twice on my end so I tried to clean up the duplicate and now it looks like none survived 😬)

@amaanq
Copy link
Member Author

amaanq commented Oct 15, 2024

Do we no longer run the local tests in ci? It looks like we just parse example files

(Sorry for deleting your comment---it came through twice on my end so I tried to clean up the duplicate and now it looks like none survived 😬)

Hm what do you mean by the local tests? iirc tree-sitter test is still invoked, as well as tests for every binding.

And no worries, I was on mobile with poor connection so it sent twice

@calebdw
Copy link
Collaborator

calebdw commented Oct 15, 2024

Unless I'm missing something I don't see tree-sitter test as part of these workflows:

image

@amaanq
Copy link
Member Author

amaanq commented Oct 15, 2024

It's a step in the workflow
image

@calebdw
Copy link
Collaborator

calebdw commented Oct 15, 2024

Ah, I see it now, it was nested in between the clones and I skipped over it thinking it was the example parsing:

      - name: Run tests
        uses: tree-sitter/parser-test-action@v2
        with:
          test-rust: true
          test-node: true
          test-python: true
          test-go: true
          test-swift: true

Everything looks good to me, thanks for all your hard work on tree-sitter! I love the more frequent releases :)

@calebdw
Copy link
Collaborator

calebdw commented Oct 15, 2024

Do you know why node v23 isn't downloading?

https://github.com/tree-sitter/tree-sitter-php/actions/runs/11348329979/job/31562460626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants