Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add license to Cargo.toml #193

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

look
Copy link
Contributor

@look look commented Oct 23, 2023

This package cannot be published to crates.io without it.

Checklist:

  • All tests pass in CI
  • There are sufficient tests for the new fix/feature
  • Grammar rules have not been renamed unless absolutely necessary (x rules renamed)
  • The conflicts section hasn't grown too much (x new conflicts)
  • The parser size hasn't grown too much (master: STATE_COUNT, PR: STATE_COUNT) (check the value of STATE_COUNT in src/parser.c)

This package cannot be published to crates.io without it.
@look
Copy link
Contributor Author

look commented Oct 23, 2023

@dcreager thanks for the review. After merging this, I think it would be best to update the Cargo.toml and package.json and tag a new release, because otherwise the artifact published to crates.io will not match the tag (unless I misunderstand how it works).

@dcreager dcreager merged commit 33e3016 into tree-sitter:master Oct 25, 2023
3 checks passed
maxdeviant added a commit to zed-industries/zed that referenced this pull request Jan 27, 2024
This PR upgrades `tree-sitter-php` to v0.21.1.

Here is the diff between our current version and this version:
tree-sitter/tree-sitter-php@d43130f...29a49d3

The primary impetus for this change is to get this change that adds the
`license` field to the `Cargo.toml`:
tree-sitter/tree-sitter-php#193

This will silence the warning that is shown when running
`script/generate-licenses`.

Release Notes:

- Upgraded `tree-sitter-php` to v0.21.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants