Fix wrong parsing when a function call with a (one or more) variable … #327
Conversation
…is inside a using statement. Instead of being parsed as invocation_expression it is being parsed as variable_declaration because of tuple_pattern.
|
Might be an acceptable fix for: |
|
So while it solves one individual issue this breaks things by renaming Best option here might be to see if you can keep the new using patterns but alias them so they don't have the using prefix (there are some examples in the grammar). |
| using_variable_declaration: $ => seq( | ||
| field('type', $._type), | ||
| commaSep1($.using_variable_declarator) | ||
| ), |
There was a problem hiding this comment.
I think using_variable_declaration could be reused in fixed_statement too, so I'd rename it to variable_declaration_no_tuple, or something similar.
There was a problem hiding this comment.
I'd really prefer we keep the names aligned with Roslyn. Apart from the compatibility it really helps understanding how the grammar rules change given the ongoing evolution of C#.
|
|
||
| using_variable_declarator: $ => seq( | ||
| field('name', $.identifier), | ||
| optional($.bracketed_argument_list), |
There was a problem hiding this comment.
Do we need optional($.bracketed_argument_list)? Why was it added to variable_declarator in the first place?
There was a problem hiding this comment.
@damieng Can you think of a case when we'd need the bracketed_argument_list in variable_declarator? I reran the tests without it, and everything passes.
| using_variable_declarator: $ => seq( | ||
| field('name', $.identifier), | ||
| optional($.bracketed_argument_list), | ||
| optional($.equals_value_clause) |
There was a problem hiding this comment.
Is it really optional to have an equals_value_clause in a using statement?
| using_statement: $ => seq( | ||
| optional('await'), | ||
| 'using', | ||
| '(', | ||
| choice($.variable_declaration, $._expression), | ||
| choice($.using_variable_declaration, $._expression), |
There was a problem hiding this comment.
| choice($.using_variable_declaration, $._expression), | |
| choice(alias($.using_variable_declaration, $.variable_declaration), $._expression), |
| @@ -226,6 +226,7 @@ | |||
|
|
|||
| ;; Variable declarations | |||
| (variable_declarator (identifier) @variable) | |||
| (using_variable_declarator (identifier) @variable) | |||
There was a problem hiding this comment.
I think we wouldn't need this if the alias was added.
|
@damieng @tamasvajk First of all, thanks for taking a look. Much appreciated. |
…is inside a using statement. Instead of being parsed as invocation_expression it is being parsed as variable_declaration because of tuple_pattern.