Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ts_tree_edit #321

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Add ts_tree_edit #321

merged 4 commits into from
Sep 23, 2024

Conversation

crumbtoo
Copy link
Contributor

This currently pulls in {eval,peek,poke}Struct from TreeSitter.Node. Perhaps these should be moved to some TreeSitter.Internal module?

@crumbtoo
Copy link
Contributor Author

@Kleidukos

@Kleidukos Kleidukos self-assigned this Sep 21, 2024
@Kleidukos
Copy link
Contributor

Excellent. I see this is binding to a new C function through FFI. Does this require a minimum version for the tree-sitter library?

@crumbtoo
Copy link
Contributor Author

crumbtoo commented Sep 22, 2024 •
edited
Loading

As far as I'm aware, ts_tree_edit has been there since the first release:
https://github.com/tree-sitter/tree-sitter/blob/0.14.0-beta2/lib/include/tree_sitter/api.h#L102

@Kleidukos
Copy link
Contributor

Thank you very much @crumbtoo!

@Kleidukos
Copy link
Contributor

@crumbtoo oh wait, if I may ask one more thing: Could you please add an entry in the changelog?

@Kleidukos Kleidukos merged commit bf614b3 into tree-sitter:master Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kleidukos Kleidukos Kleidukos approved these changes

Assignees

@Kleidukos Kleidukos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crumbtoo @Kleidukos @msyds