Enable installing static library for MRI 2.4 and 2.5 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpapis
reviewed
Nov 29, 2017
build.sh
Outdated
| EXTRA_CONFIGURE_OPTS=",--enable-install-static-library" | ||
| fi | ||
|
|
||
| announce rvm install $RUBY $EXTRA_FLAGS --verify-downloads 1 $MOVABLE_FLAG --disable-install-doc -C --without-tcl,--without-tk,--without-gmp$EXTRA_CONFIGURE_OPTS;; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
d-unsed
force-pushed
the
ruby_2_4_static_lib
branch
from
d394d65 to
4628c2f
Compare
|
I've implemented a slightly different solution from what you suggested. RVM docs say that custom configure options should be passed as a comma-separated list using Also, I'm definitely not a shell scripting expert, so feel free to request for more changes :) |
|
The docs is just few options of many, the -- is easier for handling
multiple config options with arrays as in my example
…On Nov 30, 2017 17:04, "Dmitry Gritsay" ***@***.***> wrote:
@mpapis <https://github.com/mpapis>,
I've implemented a slightly different solution from what you suggested. RVM
docs <https://rvm.io/rvm/cli> say that custom configure options should be
passed as a comma-separated list using -C parameter:
-C - custom configure options, comma separated, double quote
args that need quoting, default: --enable-shared=true
Also, I'm definitely not a shell scripting expert, so feel free to request
for more changes :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAC7titqR9vicO8n8QZth3i433WTvcABks5s7tHvgaJpZM4QvNyz>
.
|
d-unsed
force-pushed
the
ruby_2_4_static_lib
branch
from
4628c2f to
992d99e
Compare
d-unsed
changed the title
|
Got it! I changed to use plain arrays for |
- Install both static and dynamic libraries for MRI 2.4 and 2.5
d-unsed
force-pushed
the
ruby_2_4_static_lib
branch
from
992d99e to
ebd0597
Compare
|
@mpapis, looks like there was some random failure related to GPG keys in the test env. I've restarted the build, all green now. |
mpapis
approved these changes
Dec 12, 2017
d-unsed
force-pushed
the
ruby_2_4_static_lib
branch
from
eef89c1 to
7769d86
Compare
d-unsed
force-pushed
the
ruby_2_4_static_lib
branch
from
7769d86 to
b2b6922
Compare
|
Newlines fixed |
|
Sorry for overlooking this one. Does this apply to |
BanzaiMan
added a commit
that referenced
this pull request
Nov 1, 2018
Enable installing static library for MRI 2.4 and 2.5
BanzaiMan
reviewed
Nov 1, 2018
| announce rvm install $RUBY $EXTRA_FLAGS --verify-downloads 1 $MOVABLE_FLAG --disable-install-doc -C --without-tcl,--without-tk,--without-gmp;; | ||
| CONFIGURE_OPTS=( --without-tcl --without-tk --without-gmp ) | ||
| case $RUBY in | ||
| ruby-2.4*|ruby-2.5*) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! There was a breaking change introduced in Ruby 2.4 related to static and shared libraries.
Pre-2.4 behavior:
libruby-static.a)--enable-sharedoption, additionally install shared library (libruby.x.y.z.so)2.4.x behavor:
--enable-shared, install only dynamic library--enable-sharedand--enable-install-static-library, install both shared and static libsBy default RVM uses
--enable-sharedflag. So it means that currently the pre-built rubies for 2.4.x have only shared libs. Some projects (like ruby-sys or ruru) explicitly test linking for both kinds of libraries. So their builds for 2.4.x fail, because those RVM images don't have static libs.This patch adds
--enable-install-static-librarytoruby-2.4*, so that their RVM images have both kind of libraries, like2.3.xand prior versions.