Pull user login/name from pusher field when sender is nil
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some payloads come in that are missing a `sender` field for one reason or another, but they do seem to have a `pusher` field, which has a `name` field that is the same as the ['sender']['login'] value.
kerrizor
force-pushed
the
kerrizor/pull-user-login-from-pusher-field-when-sender-is-missing-from-payload
branch
from
b62ffb4 to
5a342d7
Compare
|
Can we also escalate this to GitHub to understand if this is a bug on their end or a use case we need to handle long term? |
kerrizor
commented
Aug 16, 2018
| @@ -179,6 +179,7 @@ def event_details | |||
| rescue => e | |||
| error("Error logging payload: #{e.message}") | |||
| error("Payload causing error: #{decoded_payload}") | |||
| error("Original payload causing error: #{payload}") | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
joshk
reviewed
Aug 16, 2018
| # or another, but they do seem to have a `pusher` field, which has a | ||
| # `name` field that is the same as the ['sender']['login'] value. | ||
| # | ||
| def self.parse_sender_from(payload) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
vitalied
force-pushed
the
master
branch
3 times, most recently
from
a8db366 to
dc6e06b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some payloads come in that are missing a
senderfield for one reason or another, but they do seem to have apusherfield, which has anamefield that is the same as the ['sender']['login'] value.This isn't a common issue, but a persistent one, always buzzing in the background of .org and .com.
https://sentry.io/travis-ci/org-listener-production/issues/587467865/
https://sentry.io/travis-ci/com-listener-production/issues/562523767/
I assume that these are valid build requests; nothing in the payloads I snagged via logging I put into place earlier today (in #45) appear to be invalid, just missing the
API docs, I can't see any v3 API events that don't have a
sendervalue for whatever reason. Cruising throughsenderfield, but the data simply isn't there. A few DO call out thatpusheris expected in the payload as well, and contains a different, less-rich version of thesenderdata, which implies it might be some legacy API is pushing events at us. Since all we want/need it theloginornamevalue, this seems like a small patch to cover ourselves in this case.