Import types consistently from @uppy/core

[Murderlon]

It's always better to import from your own package roots like your users would.

Also added a new eslint rule to prevent imports from src/.

Ref: #5584
Ref: #5559

[github-actions]

Diff output files

diff --git a/packages/@uppy/aws-s3/lib/index.js b/packages/@uppy/aws-s3/lib/index.js
index fdacf39..1e4c029 100644
--- a/packages/@uppy/aws-s3/lib/index.js
+++ b/packages/@uppy/aws-s3/lib/index.js
@@ -7,7 +7,7 @@ function _classPrivateFieldLooseKey(e) {
   return "__private_" + id++ + "_" + e;
 }
 import { RequestClient } from "@uppy/companion-client";
-import BasePlugin from "@uppy/core/lib/BasePlugin.js";
+import { BasePlugin } from "@uppy/core";
 import EventManager from "@uppy/core/lib/EventManager.js";
 import { createAbortError } from "@uppy/utils/lib/AbortController";
 import { filterFilesToEmitUploadStarted, filterNonFailedFiles } from "@uppy/utils/lib/fileFilters";
diff --git a/packages/@uppy/core/lib/index.js b/packages/@uppy/core/lib/index.js
index 6c10dc2..21b75a9 100644
--- a/packages/@uppy/core/lib/index.js
+++ b/packages/@uppy/core/lib/index.js
@@ -1,5 +1,4 @@
 export { default as BasePlugin } from "./BasePlugin.js";
 export { debugLogger } from "./loggers.js";
 export { default as UIPlugin } from "./UIPlugin.js";
-export { default } from "./Uppy.js";
-export { default as Uppy } from "./Uppy.js";
+export { default, default as Uppy } from "./Uppy.js";
diff --git a/packages/@uppy/drop-target/lib/index.js b/packages/@uppy/drop-target/lib/index.js
index ac16fa4..dff1b9b 100644
--- a/packages/@uppy/drop-target/lib/index.js
+++ b/packages/@uppy/drop-target/lib/index.js
@@ -1,4 +1,4 @@
-import BasePlugin from "@uppy/core/lib/BasePlugin.js";
+import { BasePlugin } from "@uppy/core";
 import getDroppedFiles from "@uppy/utils/lib/getDroppedFiles";
 import toArray from "@uppy/utils/lib/toArray";
 const packageJson = {
diff --git a/packages/@uppy/form/lib/index.js b/packages/@uppy/form/lib/index.js
index cf3b31a..753c87e 100644
--- a/packages/@uppy/form/lib/index.js
+++ b/packages/@uppy/form/lib/index.js
@@ -6,7 +6,7 @@ var id = 0;
 function _classPrivateFieldLooseKey(e) {
   return "__private_" + id++ + "_" + e;
 }
-import BasePlugin from "@uppy/core/lib/BasePlugin.js";
+import { BasePlugin } from "@uppy/core";
 import findDOMElement from "@uppy/utils/lib/findDOMElement";
 import toArray from "@uppy/utils/lib/toArray";
 import getFormData from "get-form-data";
diff --git a/packages/@uppy/golden-retriever/lib/index.js b/packages/@uppy/golden-retriever/lib/index.js
index 1a10a45..d8b60bb 100644
--- a/packages/@uppy/golden-retriever/lib/index.js
+++ b/packages/@uppy/golden-retriever/lib/index.js
@@ -1,4 +1,4 @@
-import BasePlugin from "@uppy/core/lib/BasePlugin.js";
+import { BasePlugin } from "@uppy/core";
 import throttle from "lodash/throttle.js";
 import IndexedDBStore from "./IndexedDBStore.js";
 import MetaDataStore from "./MetaDataStore.js";
diff --git a/packages/@uppy/transloadit/lib/index.js b/packages/@uppy/transloadit/lib/index.js
index e86dfea..1632268 100644
--- a/packages/@uppy/transloadit/lib/index.js
+++ b/packages/@uppy/transloadit/lib/index.js
@@ -6,7 +6,7 @@ var id = 0;
 function _classPrivateFieldLooseKey(e) {
   return "__private_" + id++ + "_" + e;
 }
-import BasePlugin from "@uppy/core/lib/BasePlugin.js";
+import { BasePlugin } from "@uppy/core";
 import Tus from "@uppy/tus";
 import ErrorWithCause from "@uppy/utils/lib/ErrorWithCause";
 import hasProperty from "@uppy/utils/lib/hasProperty";
diff --git a/packages/@uppy/tus/lib/index.js b/packages/@uppy/tus/lib/index.js
index c53394f..650bb19 100644
--- a/packages/@uppy/tus/lib/index.js
+++ b/packages/@uppy/tus/lib/index.js
@@ -6,7 +6,7 @@ var id = 0;
 function _classPrivateFieldLooseKey(e) {
   return "__private_" + id++ + "_" + e;
 }
-import BasePlugin from "@uppy/core/lib/BasePlugin.js";
+import { BasePlugin } from "@uppy/core";
 import EventManager from "@uppy/core/lib/EventManager.js";
 import { filterFilesToEmitUploadStarted, filterNonFailedFiles } from "@uppy/utils/lib/fileFilters";
 import getAllowedMetaFields from "@uppy/utils/lib/getAllowedMetaFields";
diff --git a/packages/@uppy/xhr-upload/lib/index.js b/packages/@uppy/xhr-upload/lib/index.js
index db3ca94..2f9c967 100644
--- a/packages/@uppy/xhr-upload/lib/index.js
+++ b/packages/@uppy/xhr-upload/lib/index.js
@@ -6,7 +6,7 @@ var id = 0;
 function _classPrivateFieldLooseKey(e) {
   return "__private_" + id++ + "_" + e;
 }
-import BasePlugin from "@uppy/core/lib/BasePlugin.js";
+import { BasePlugin } from "@uppy/core";
 import EventManager from "@uppy/core/lib/EventManager.js";
 import { fetcher } from "@uppy/utils/lib/fetcher";
 import { filterFilesToEmitUploadStarted, filterNonFailedFiles } from "@uppy/utils/lib/fileFilters";

[mifi]

sgtm except:

• type tests are failing
• e2e tests are failing
• could this be enforced by eslint or something else? i will 100% forget to do this some time in the future, and i'm sure other contributors could too