Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle max_depth in tree solver #50

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

EgorKraevTransferwise
Copy link
Collaborator

Context

Fix the way tree solver handles max_depth; align interpretation with rest of package and make sure it's actually enforced

Checklist

@wise-github-bot-app
Copy link

🔴

Your CODEOWNERS file is broken, fix the following errors before merging the branch:

  • The CODEOWNERS file does not exist. Repository ownership will default to ENGINEERING until you add a CODEOWNERS file with a * rule that assigns it to a team

@wise-github-bot-app
Copy link

The approval(s) from AlxdrPolyakov do(es)n't fullfill the approvers requirements because:

  • The approver's cost centre, PRDANA, maps to the ANALYST business function. As the code that was changed is owned by ENGINEERING, this approval won't satisfy our separation of duties check. We'll need an additional approval from someone in ENGINEERING. This approval may still help satisfy other codeowner requirements.

@AlxdrPolyakov AlxdrPolyakov merged commit 2d9dcd9 into main May 13, 2024
8 of 9 checks passed
@AlxdrPolyakov AlxdrPolyakov deleted the tree_depth branch September 5, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants