Optimise deleteByTypeAndClient method #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveking-tw
changed the title
daveking-tw
changed the title
| @@ -0,0 +1,2 @@ | |||
| CREATE INDEX IF NOT EXISTS IDX_IDEMPOTENT_ACTION_TYPE_CLIENT | |||
There was a problem hiding this comment.
I was just googling to see if there's a mariadb equivalent of concurrently - looks like adding ALGORITHM=INPLACE LOCK=NONE may do the trick?
| @@ -137,7 +137,6 @@ public int[] deleteByIds(List<ActionId> actionIdList) { | |||
| "DELETE FROM idempotent_action " + | |||
| "WHERE type = :type " + | |||
| " AND client = :client " + | |||
| "ORDER BY created_at ASC " + | |||
There was a problem hiding this comment.
This was a good spot - it's not necessary for this to be deterministic!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Context
On applications with large
idempotent_actiontables,deleteByTypeAndClientcan be optimised by removing the need to sort actions before delete🚀 Changes
deleteByTypeAndClientqueriesdeleteByTypeAndClientqueries to let db return/delete records in natural order without the overhead of sortingConsiderations
Actions will no longer be deleted oldest first