Merge with scrobbler

[rafaelgomesxyz]

Fixes #19

Still need to merge the actual scrobblers, but most of it is done.

[rafaelgomesxyz]

Alright, think I'm done here.

[rafaelgomesxyz]

The only bug I'm experiencing is that sometimes the popup doesn't load, which appears to be the same bug that affects traktflix (tegon/traktflix#100). But after about 3 times of clicking the button, it loads. I'm trying to see what's causing this.

Edit: Actually, doesn't look like it's that issue, but I was sure this also happened in traktflix.

[MrMamen]

I get an error when toggling: Show browser notifications. (Failed to save option.)

[MrMamen]

I get an error when toggling: Show browser notifications. (Failed to save option.)

Same with Netflix. Not able to disable it.

[rafaelgomesxyz]

I get an error when toggling: Show browser notifications. (Failed to save option.)

For notifications, it's because I forgot to add the notifications permission to the manifest, but I don't know why you can't disable Netflix. I'll test with a clean profile.

[MrMamen]

I get an error when toggling: Show browser notifications. (Failed to save option.)

For notifications, it's because I forgot to add the notifications permission to the manifest, but I don't know why you can't disable Netflix. I'll test with a clean profile.

Probably related but I'm not able to scrobble from Netflix either. I did try to clean all cache & data, but same problem.

[rafaelgomesxyz]

Probably related but I'm not able to scrobble from Netflix either. I did try to clean all cache & data, but same problem.

Ok, I can reproduce it on Chromium.

Edit: This is a bizarre error. It looks like the extension still thinks that Netflix is a required permission. I tried completely wiping the extension from my Chromium folder and it still thinks that.

[rafaelgomesxyz]

Ok, I fixed the scrobble bug.

As for not being able to disable Netflix, I think this is because we're loading the extension as unpacked, so it considers all permissions as required. I don't think this should happen with an actual extension coming from the store.

[MrMamen]

Ok, I fixed the scrobble bug.

As for not being able to disable Netflix, I think this is because we're loading the extension as unpacked, so it considers all permissions as required. I don't think this should happen with an actual extension coming from the store.

But why are the others toggable?

[rafaelgomesxyz]

Ok, I fixed the scrobble bug.
As for not being able to disable Netflix, I think this is because we're loading the extension as unpacked, so it considers all permissions as required. I don't think this should happen with an actual extension coming from the store.

But why are the others toggable?

They're not toggable for me. Probably because I erased the extension and added it again.

[MrMamen]

Ok, I fixed the scrobble bug.
As for not being able to disable Netflix, I think this is because we're loading the extension as unpacked, so it considers all permissions as required. I don't think this should happen with an actual extension coming from the store.

But why are the others toggable?

They're not toggable for me. Probably because I erased the extension and added it again.

Just for the record. The services with scrobbling are not toggable for me, but the ones with just history sync are.