Skip to content

fix: update how we handle the no policies and no user when dealing with permissions #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix: update how we handle the no policies and no user when dealing with permissions #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libs/nestjs/casl/src/guards/policies-guard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ export class PoliciesGuard implements CanActivate {
context.getHandler(),
) || [];

// If no policies are defined, allow the request
if (policyHandlers.length === 0) return true;

const contextType: string = context.getType();

// Skip the guard for rabbitmq requests
Expand Down
9 changes: 3 additions & 6 deletions libs/nestjs/casl/src/services/casl.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,10 @@ export class CaslAbilityFactoryService {

const { rolePermissions, publicPermissions } = this.caslOptions;

if (!user && publicPermissions) {
publicPermissions(builder);
return builder.build();
}

// If no user is provided, only allow public permissions
if (!user) {
throw new UnauthorizedException();
if (typeof publicPermissions === 'function') publicPermissions(builder);
return builder.build();
}

const roles = this.getRoles(user);
Expand Down