Merge local and remote runs #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regenerated Cargo.lock to fix some vulnerabilities Co-authored-by: Jonathan Richard <[email protected]>
If the --runner flag is specified, the run will be remote on that runner
# Conflicts: # Cargo.lock # crates/heat-sdk-cli/src/cli_commands/run/remote/training.rs # examples/guide-cli/src/main.rs
syl20bnr
reviewed
Jan 20, 2025
Fix problems linked to PR
syl20bnr
approved these changes
Jan 21, 2025
| (Some(_), Some(_)) => remote_run(args, context), | ||
| (None, None) => local_run(args, context), | ||
| (Some(_), None) => Err(anyhow::anyhow!("You must provide the project version to run on the runner with --version argument")), | ||
| (None, Some(_)) => Err(anyhow::anyhow!("Project version is ignored when executing locally (i.e. no runner is defined with --runner argument")) |
There was a problem hiding this comment.
I think we can make it just a warning and continue executing locally.
The message can be tweaked like that:
"Project version is ignored when executing locally (i.e. no runner is defined with --runner argument). Running locally uses the current version on the local machine."
syl20bnr
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the local and remote training commands.
It is now required for the git repo to not be dirty before packaging or running a project.
Project versions are now commit hashes instead of auto-incrementing numbers returned by heat.
Requires the corresponding PR in
heatto be merged to work: https://github.com/tracel-ai/heat/pull/100