Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bitwise not unary op #434

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

quinton11
Copy link
Contributor

@quinton11 quinton11 commented Jan 19, 2025

Patch for #270

Rust uses ! for both logical and bitwise not, where the operand differentiates the use; i.e bool for logical and int variations for bitwise

wgsl however uses ! for logical not and ~ for bitwise not.

The Not op is still kept in tact as it was, handling boolean operands,

Tests now pass for the bitwisenot operation on burn_jit backends. When this is merged, I'll push the changes to bitwise_ops PR here

@laggui

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit 6eafb7f into tracel-ai:main Jan 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants