Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types under autotune flag #2750

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix types under autotune flag #2750

merged 1 commit into from
Jan 28, 2025

Conversation

laggui
Copy link
Member

@laggui laggui commented Jan 27, 2025

Checklist

  • Confirmed that run-checks all script has been executed.

Changes

  • Fixed visibility of types / functions only available with "autotune" feature (and some incorrect names)
  • Propagate autotune feature flag to burn-cuda and burn-hip (when using default-features = false, enabling autotune would only work for wgpu)

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.57%. Comparing base (fae641f) to head (f14e126).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2750      +/-   ##
==========================================
+ Coverage   83.56%   83.57%   +0.01%     
==========================================
  Files         824      824              
  Lines      108465   108453      -12     
==========================================
+ Hits        90638    90639       +1     
+ Misses      17827    17814      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit 04c5e74 into main Jan 28, 2025
11 checks passed
@nathanielsimard nathanielsimard deleted the fix/no-autotune branch January 28, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants