Fixed typo in the burn book chapter advanced unit no-std. #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"deice" -> "device"
laggui
reviewed
Jan 22, 2025
There was a problem hiding this comment.
At least the typo was consistent across the type usage 😅 But good catch
Since the code is linked to the accompanying example, do you mind reflecting the changes there as well?
|
Sure thing. The code in the example is also changed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2731 +/- ##
==========================================
+ Coverage 83.59% 83.91% +0.32%
==========================================
Files 819 821 +2
Lines 106600 106890 +290
==========================================
+ Hits 89113 89702 +589
+ Misses 17487 17188 -299 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
changed "BackendDeice" -> "BackendDevice" in the example code.