Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to type magic autotune #2710

Merged
merged 6 commits into from
Jan 20, 2025
Merged

Conversation

wingertge
Copy link
Contributor

@wingertge wingertge commented Jan 17, 2025

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Migrates to changes made in tracel-ai/cubecl#430

Changes

Removes tune macro uses and migrates to new API.

Testing

All tests passing

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 84.32836% with 21 lines in your changes missing coverage. Please review.

Project coverage is 83.60%. Comparing base (6750fd6) to head (49e2810).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/burn-jit/src/kernel/conv/conv2d/implicit_gemm.rs 45.94% 20 Missing ⚠️
crates/burn-jit/src/kernel/conv/error.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2710      +/-   ##
==========================================
+ Coverage   83.36%   83.60%   +0.24%     
==========================================
  Files         819      819              
  Lines      106661   106600      -61     
==========================================
+ Hits        88916    89124     +208     
+ Misses      17745    17476     -269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wingertge wingertge marked this pull request as ready for review January 19, 2025 18:10
@nathanielsimard nathanielsimard merged commit 949e77f into tracel-ai:main Jan 20, 2025
11 checks passed
@wingertge wingertge deleted the autotune branch January 20, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants