Upgrade to wgpu 22.0.0 #2040
Closed
Upgrade to wgpu 22.0.0 #2040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2040 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 847 847
Lines 105481 105486 +5
=======================================
+ Hits 88849 88857 +8
+ Misses 16632 16629 -3 ☔ View full report in Codecov by Sentry. |
|
@ArthurBrussee Most of the codebase now lives on the CubeCL repo, can you made the PR there instead? I'm actively working on the migration, should land very soon on the burn main branch. |
|
Yeah makes sense, will create a PR there once the migration lands! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Changes
Upgrade wgpu to 22.0.0. There's two breaking things:
Have to specifiy a MemoryHint, choosing between performance and lower memory usage. GIven wgpu has it's own block allocator now, MemoryUsage seems better. I did a quick test on the train sample and see no clear performance difference between either.
Need to specify a pipeline cache. This allows to cache compiled shader outputs. As per the comment in the wgpu code this is usually done automatically though not on Android seemingly. Could be nice someday.