Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to candle 0.4.1 #1382

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Upgrade to candle 0.4.1 #1382

merged 4 commits into from
Feb 29, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Feb 29, 2024

The candle team recently released version 0.4.0 (and 0.4.1 patch) which will fix a couple of issues we've been waiting on.

Checklist

  • Confirmed that run-checks all script has been executed (on both linux/win).
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Closes issue #1178
PR #1300 will be able to be merged

Changes

  • Fixed python main entrypoint in pytorch import book example (def main() was never called)
  • Removed candle windows safeguards
  • Bumped candle-core from 0.3.3 to 0.4.1

@laggui laggui requested a review from antimora February 29, 2024 14:07
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.44%. Comparing base (40bf392) to head (ed03df3).

Files Patch % Lines
crates/burn-candle/src/ops/module.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1382   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files         593      593           
  Lines       67968    67966    -2     
=======================================
  Hits        58076    58076           
+ Misses       9892     9890    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding all the issues and fixing them.

@antimora antimora merged commit 4efc683 into main Feb 29, 2024
14 of 15 checks passed
@antimora antimora deleted the chore/candle-0.4.0 branch February 29, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants