Pytorch message updates #1344
Merged
Pytorch message updates #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1344 +/- ##
=======================================
Coverage 78.77% 78.77%
=======================================
Files 551 551
Lines 61836 61836
=======================================
Hits 48712 48712
Misses 13124 13124 ☔ View full report in Codecov by Sentry. |
laggui
approved these changes
Feb 22, 2024
| @@ -230,7 +230,8 @@ Which produces the following weights structure (viewed in | |||
|
|
|||
| You can use the `PyTorchFileRecorder` to change the attribute names and the order of the attributes | |||
| by specifying a regular expression (See | |||
| [regex::Regex::replace](https://docs.rs/regex/latest/regex/struct.Regex.html#method.replace)) to | |||
| [regex::Regex::replace](https://docs.rs/regex/latest/regex/struct.Regex.html#method.replace) and | |||
| [try it online](https://rregex.dev/?version=1.10&method=replace)) to | |||
There was a problem hiding this comment.
Oh very cool I didn't know there was an online sandbox to mess around with regex. I always used regex101 but it's not a 1-to-1 due to string formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Changes
Minor updates to the book and error message.
Testing
Manually using local script.