[clippy] reported by reviewdog 🐶 error: this `if` statement can be collapsed --> burn-import/src/onnx/from_onnx.rs:343:9 | 343 | / if node.node_type == NodeType::Unsqueeze { 344 | | if node.inputs[1].value.is_none() { 345 | | if let Some(in_arg) = graph_io.get(&node.outputs[0].name) { 346 | | remap_unsqueeze_to_reshape(node, in_arg); 347 | | } 348 | | } 349 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `-D clippy::collapsible-if` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]` help: collapse nested if block | 343 ~ if node.node_type == NodeType::Unsqueeze && node.inputs[1].value.is_none() { 344 + if let Some(in_arg) = graph_io.get(&node.outputs[0].name) { 345 + remap_unsqueeze_to_reshape(node, in_arg); 346 + } 347 + } | Raw Output: burn-import/src/onnx/from_onnx.rs:343:9:e:error: this `if` statement can be collapsed --> burn-import/src/onnx/from_onnx.rs:343:9 | 343 | / if node.node_type == NodeType::Unsqueeze { 344 | | if node.inputs[1].value.is_none() { 345 | | if let Some(in_arg) = graph_io.get(&node.outputs[0].name) { 346 | | remap_unsqueeze_to_reshape(node, in_arg); 347 | | } 348 | | } 349 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `-D clippy::collapsible-if` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]` help: collapse nested if block | 343 ~ if node.node_type == NodeType::Unsqueeze && node.inputs[1].value.is_none() { 344 + if let Some(in_arg) = graph_io.get(&node.outputs[0].name) { 345 + remap_unsqueeze_to_reshape(node, in_arg); 346 + } 347 + } | __END__

[clippy] reported by reviewdog 🐶 error: variable does not need to be mutable --> burn-import/src/onnx/from_onnx.rs:407:17 | 407 | inputs: mut inner_inputs, | ----^^^^^^^^^^^^ | | | help: remove this `mut` | = note: `-D unused-mut` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_mut)]` Raw Output: burn-import/src/onnx/from_onnx.rs:407:17:e:error: variable does not need to be mutable --> burn-import/src/onnx/from_onnx.rs:407:17 | 407 | inputs: mut inner_inputs, | ----^^^^^^^^^^^^ | | | help: remove this `mut` | = note: `-D unused-mut` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_mut)]` __END__

[clippy] reported by reviewdog 🐶 error: variable does not need to be mutable --> burn-import/src/onnx/from_onnx.rs:408:18 | 408 | outputs: mut inner_outputs, | ----^^^^^^^^^^^^^ | | | help: remove this `mut` Raw Output: burn-import/src/onnx/from_onnx.rs:408:18:e:error: variable does not need to be mutable --> burn-import/src/onnx/from_onnx.rs:408:18 | 408 | outputs: mut inner_outputs, | ----^^^^^^^^^^^^^ | | | help: remove this `mut` __END__

[clippy] reported by reviewdog 🐶 error: function `convert_node2` is never used --> burn-import/src/onnx/coalesce.rs:189:15 | 189 | pub(crate) fn convert_node2(bias_node: &Node, mut current_node: RefMut<'_, Node>) { | ^^^^^^^^^^^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` Raw Output: burn-import/src/onnx/coalesce.rs:189:15:e:error: function `convert_node2` is never used --> burn-import/src/onnx/coalesce.rs:189:15 | 189 | pub(crate) fn convert_node2(bias_node: &Node, mut current_node: RefMut<'_, Node>) { | ^^^^^^^^^^^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` __END__

[clippy] reported by reviewdog 🐶 error: needlessly taken reference of both operands --> burn-import/src/onnx/from_onnx.rs:295:12 | 295 | if &node.node_type == &NodeType::Linear { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `-D clippy::op-ref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::op_ref)]` help: use the values directly | 295 | if node.node_type == NodeType::Linear { | ~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~ Raw Output: burn-import/src/onnx/from_onnx.rs:295:12:e:error: needlessly taken reference of both operands --> burn-import/src/onnx/from_onnx.rs:295:12 | 295 | if &node.node_type == &NodeType::Linear { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `-D clippy::op-ref` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::op_ref)]` help: use the values directly | 295 | if node.node_type == NodeType::Linear { | ~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~ __END__

[clippy] reported by reviewdog 🐶 error: needlessly taken reference of both operands --> burn-import/src/onnx/from_onnx.rs:311:12 | 311 | if &node.node_type == &NodeType::Constant | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 311 | if node.node_type == NodeType::Constant | ~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~ Raw Output: burn-import/src/onnx/from_onnx.rs:311:12:e:error: needlessly taken reference of both operands --> burn-import/src/onnx/from_onnx.rs:311:12 | 311 | if &node.node_type == &NodeType::Constant | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 311 | if node.node_type == NodeType::Constant | ~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~ __END__

[clippy] reported by reviewdog 🐶 error: needlessly taken reference of both operands --> burn-import/src/onnx/from_onnx.rs:312:17 | 312 | || (&node.node_type == &NodeType::Identity && node.inputs[0].value.is_some()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 312 | || (node.node_type == NodeType::Identity && node.inputs[0].value.is_some()) | ~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~ Raw Output: burn-import/src/onnx/from_onnx.rs:312:17:e:error: needlessly taken reference of both operands --> burn-import/src/onnx/from_onnx.rs:312:17 | 312 | || (&node.node_type == &NodeType::Identity && node.inputs[0].value.is_some()) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref help: use the values directly | 312 | || (node.node_type == NodeType::Identity && node.inputs[0].value.is_some()) | ~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~ __END__

reviewdog exited with status code: 1

The job was canceled because "ubuntu-22_04_stable_std" failed.

The operation was canceled.

The job was canceled because "ubuntu-22_04_stable_std" failed.

The operation was canceled.

The job was canceled because "ubuntu-22_04_stable_std" failed.

The operation was canceled.

The job was canceled because "ubuntu-22_04_stable_std" failed.

The operation was canceled.

The job was canceled because "ubuntu-22_04_stable_std" failed.

The operation was canceled.

The job was canceled because "ubuntu-22_04_stable_std" failed.

The operation was canceled.

The job was canceled because "ubuntu-22_04_stable_std" failed.

The operation was canceled.

The job was canceled because "ubuntu-22_04_stable_std" failed.

The operation was canceled.

The job was canceled because "ubuntu-22_04_stable_std" failed.

The operation was canceled.

The job was canceled because "ubuntu-22_04_stable_std" failed.

The operation was canceled.