Skip to content

Constant tensor support in burn-import #4916

Constant tensor support in burn-import

Constant tensor support in burn-import #4916

Triggered via pull request July 19, 2024 21:37
Status Success
Total duration 28m 32s
Artifacts

test.yml

on: pull_request
check-typos
9s
check-typos
Matrix: tests
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 1 warning
tests (ubuntu-22.04, stable, std): crates/burn-import/src/burn/graph.rs#L18
[clippy] reported by reviewdog 🐶 error: unused import: `process::exit` --> crates/burn-import/src/burn/graph.rs:18:79 | 18 | any::type_name, collections::HashMap, marker::PhantomData, path::PathBuf, process::exit, | ^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]` Raw Output: crates/burn-import/src/burn/graph.rs:18:79:e:error: unused import: `process::exit` --> crates/burn-import/src/burn/graph.rs:18:79 | 18 | any::type_name, collections::HashMap, marker::PhantomData, path::PathBuf, process::exit, | ^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unused_imports)]` __END__
tests (ubuntu-22.04, stable, std): crates/burn-import/src/burn/ty.rs#L27
[clippy] reported by reviewdog 🐶 error: method `len` is never used --> crates/burn-import/src/burn/ty.rs:28:8 | 27 | impl TensorData { | --------------- method in this implementation 28 | fn len(&self) -> usize { | ^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` Raw Output: crates/burn-import/src/burn/ty.rs:27:1:e:error: method `len` is never used --> crates/burn-import/src/burn/ty.rs:28:8 | 27 | impl TensorData { | --------------- method in this implementation 28 | fn len(&self) -> usize { | ^^^ | = note: `-D dead-code` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(dead_code)]` __END__
tests (ubuntu-22.04, stable, std): crates/burn-import/src/burn/scope.rs#L26
[clippy] reported by reviewdog 🐶 error: unneeded `return` statement --> crates/burn-import/src/burn/scope.rs:26:42 | 26 | variable.references += 1; | __________________________________________^ 27 | | return; | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 26 - variable.references += 1; 27 - return; 26 + variable.references += 1; | Raw Output: crates/burn-import/src/burn/scope.rs:26:42:e:error: unneeded `return` statement --> crates/burn-import/src/burn/scope.rs:26:42 | 26 | variable.references += 1; | __________________________________________^ 27 | | return; | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 26 - variable.references += 1; 27 - return; 26 + variable.references += 1; | __END__
tests (ubuntu-22.04, stable, std): crates/burn-import/src/burn/scope.rs#L55
[clippy] reported by reviewdog 🐶 error: this expression creates a reference which is immediately dereferenced by the compiler --> crates/burn-import/src/burn/scope.rs:55:43 | 55 | self.tensor_register_variable(&tensor, node_position); | ^^^^^^^ help: change this to: `tensor` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]` Raw Output: crates/burn-import/src/burn/scope.rs:55:43:e:error: this expression creates a reference which is immediately dereferenced by the compiler --> crates/burn-import/src/burn/scope.rs:55:43 | 55 | self.tensor_register_variable(&tensor, node_position); | ^^^^^^^ help: change this to: `tensor` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]` __END__
tests (ubuntu-22.04, stable, std): crates/burn-import/src/burn/ty.rs#L276
[clippy] reported by reviewdog 🐶 error: unneeded `return` statement --> crates/burn-import/src/burn/ty.rs:276:17 | 276 | return self.tensor_internal(self.render_row(&result)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 276 - return self.tensor_internal(self.render_row(&result)); 276 + self.tensor_internal(self.render_row(&result)) | Raw Output: crates/burn-import/src/burn/ty.rs:276:17:e:error: unneeded `return` statement --> crates/burn-import/src/burn/ty.rs:276:17 | 276 | return self.tensor_internal(self.render_row(&result)); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 276 - return self.tensor_internal(self.render_row(&result)); 276 + self.tensor_internal(self.render_row(&result)) | __END__
tests (ubuntu-22.04, stable, std): crates/burn-import/src/burn/ty.rs#L295
[clippy] reported by reviewdog 🐶 error: unneeded `return` statement --> crates/burn-import/src/burn/ty.rs:295:9 | 295 | / return match self.kind { 296 | | TensorKind::Int => quote! { 297 | | Tensor::<B,#dim>::from_ints(#tok, &self.device) 298 | | }, ... | 304 | | }, 305 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 295 ~ match self.kind { 296 + TensorKind::Int => quote! { 297 + Tensor::<B,#dim>::from_ints(#tok, &self.device) 298 + }, 299 + TensorKind::Float => quote! { 300 + Tensor::<B,#dim>::from_floats(#tok,&self.device) 301 + }, 302 + TensorKind::Bool => quote! { 303 + Tensor::<B,#dim>::from_data(#tok, &self.device) 304 + }, 305 ~ } | Raw Output: crates/burn-import/src/burn/ty.rs:295:9:e:error: unneeded `return` statement --> crates/burn-import/src/burn/ty.rs:295:9 | 295 | / return match self.kind { 296 | | TensorKind::Int => quote! { 297 | | Tensor::<B,#dim>::from_ints(#tok, &self.device) 298 | | }, ... | 304 | | }, 305 | | }; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: remove `return` | 295 ~ match self.kind { 296 + TensorKind::Int => quote! { 297 + Tensor::<B,#dim>::from_ints(#tok, &self.device) 298 + }, 299 + TensorKind::Float => quote! { 300 + Tensor::<B,#dim>::from_floats(#tok,&self.device) 301 + }, 302 + TensorKind::Bool => quote! { 303 + Tensor::<B,#dim>::from_data(#tok, &self.device) 304 + }, 305 ~ } | __END__
tests (ubuntu-22.04, stable, std)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: giraffate/clippy-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/