Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

73 object storage #74

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

73 object storage #74

wants to merge 6 commits into from

Conversation

PonponJuice
Copy link
Collaborator

@PonponJuice PonponJuice commented Jan 8, 2025

関連Issue

概要

object storage周りの基礎を追加

変更内容

  • Repositoryにobject storageを追加
  • test にupload, get object を追加
  • testするのに伴って sqlxのruntimeの変更

補足

object storage のテストは互いに干渉できるので何かすべき?しなくてもいいかも

@PonponJuice PonponJuice linked an issue Jan 8, 2025 that may be closed by this pull request
@comavius
Copy link
Member

comavius commented Jan 8, 2025

依存性の逆転をしたほうがいいと思いました

trait ObjStor {
  async fn add_content(&self, content: &str, id: Uuid) -> Result<Resp>...

のような

@kenken714
Copy link
Collaborator

@PonponJuice ハッカソン中にメンションしてしまってごめん、今これの進捗はどうですか...?

@comavius comavius self-requested a review January 17, 2025 16:56
@PonponJuice
Copy link
Collaborator Author

@PonponJuice ハッカソン中にメンションしてしまってごめん、今これの進捗はどうですか...?

今週死んでて何の作業もできてません

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

オブジェクトストレージの基礎部分作る
3 participants