-
Notifications
You must be signed in to change notification settings - Fork 109
--benchmark, fixes #217 #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
One rubocop issue remaining:
There are many ways to fix this, but I always try to avoid refactors in other people's projects :) Happy to address this if you give me some direction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the wait. Works well, most important comments are for lib/image_optim.rb, everything else is code style and nitpicks.
About tests - better to know if it will break, so at least on the level of that it works.
About TableTennis - I understand the desire to make it beautiful, but the output is so simple, that it feels excessive. From one side it shouldn't add more than few lines of code, from the other there are lots of different gems to print a table in terminal and everyone may have their preferred one.
About changelog entry - definitely and some mention in readme
lib/image_optim.rb
Outdated
dst = src.temp_path | ||
begin | ||
begin | ||
worker.optimize(src, dst, timeout: timer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if applying worker always to the original is more informative then doing it in chain (on result of previous worker) as will be done during normal operation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add a --chain
later if people like this. I think those results would be interesting as well, especially now that I've seen the worker_analysis
script
Thanks for the feedback! I added a simple test and applied the feedback. I think this is ready for another look now, no rush |
This is not done yet, but I thought you might want to take a look. Maybe something like this? See sample output below. A few questions:
Thanks!!