-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop/exclude excludeds #329
base: main
Are you sure you want to change the base?
Conversation
…eryable -if adding it to Meta.exclude works then do it, if not then return a dummy data
There are a number "core" fields for Wagtail If the goal is to return minimum information, off the top of my head, perhaps we either: Need to sleep on it. cc @dopry |
@zerolab Just to make sure you got my approach, |
Ah, thank you. I did indeed miss that when I had a cursory look. In the future, could you please:
Now, if we commit to going down this route, we need to follow a 2 release deprecation process similar to how core or Django does it (ref: https://docs.wagtail.org/en/stable/contributing/release_process.html#deprecation-policy) as this would result in backwards incompatible changes. I have more time on Friday and will look more in detail. |
@zerolab you are right, I should've describe the details in the PR |
@engAmirEng I don't really follow the changes here. I haven't dove deep into the automatic schema generation. I'm not sure what a DefaultField is or why I would want to use it. I don't understand the use case for this change. Could you update the OP to better explain your goals with these changes and how the implementation works? |
The new
DefaultField
added, if user wants to only expose some of the fields that are implemented by grapple instead of all of them then they should wrap them in this class, otherwise everything is going to work with no breaking changes and all of the grapple's fields are exposed(as they were before)