Install poetry using pip in CI scripts #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #924 +/- ##
=======================================
Coverage 52.02% 52.02%
=======================================
Files 160 160
Lines 7494 7494
Branches 166 166
=======================================
Hits 3899 3899
Misses 3476 3476
Partials 119 119 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nickmoreton
changed the title
victoriachan
reviewed
Jan 3, 2023
.circleci/config.yml
Outdated
| @@ -22,8 +22,8 @@ jobs: | |||
| - run: | |||
| name: install python dependencies | |||
| command: | | |||
| curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py | POETRY_VERSION=1.1.8 python | |||
| . $HOME/.poetry/env | |||
| pip install --upgrade pip | |||
There was a problem hiding this comment.
Have you tried replacing get-poetry.py with https://github.com/python-poetry/install.python-poetry.org? e.g. curl -sSL https://install.python-poetry.org | POETRY_VERSION=1.1.15 python3 -? I'm not sure if this is better than using pip install but it looks it looks more in line with the way it was done before.
nickmoreton
commented
Jan 3, 2023
victoriachan
approved these changes
Jan 4, 2023
Closed
kevinhowbrook
approved these changes
Jan 19, 2023
nickmoreton
commented
Jan 20, 2023
| @@ -23,7 +23,7 @@ ARG POETRY_HOME=/opt/poetry | |||
| ARG POETRY_INSTALL_ARGS="--no-dev" | |||
|
|
|||
| # IMPORTANT: Remember to review both of these when upgrading | |||
| ARG POETRY_VERSION=1.1.8 | |||
| ARG POETRY_VERSION=1.1.15 | |||
There was a problem hiding this comment.
Matches the version specified in the CI script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI command that uses this url:
curl -sSL https://raw.githubusercontent.com/python-poetry/poetry/master/get-poetry.py ...is no longer available and returns 404.
This became apparent when rebasing: #871
This updates the installation of poetry to use pip.