Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support/wagtail 62 #1052

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Support/wagtail 62 #1052

wants to merge 11 commits into from

Conversation

nickmoreton
Copy link
Contributor

No description provided.

Copy link
Contributor

@alxbridge alxbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: The customisation to the aging pages report (see AgingPagesReportView in rca/reports/views.py) appears to have stopped working - probably due to the shift to the Universal Listings UI.

pyproject.toml Show resolved Hide resolved
@nickmoreton
Copy link
Contributor Author

Issue: The customisation to the aging pages report (see AgingPagesReportView in rca/reports/views.py) appears to have stopped working - probably due to the shift to the Universal Listings UI.

Hi @alxbridge Please could you expand on the issue you have seen. It seems to be working OK for me locally.

@nickmoreton
Copy link
Contributor Author

Issue: The customisation to the aging pages report (see AgingPagesReportView in rca/reports/views.py) appears to have stopped working - probably due to the shift to the Universal Listings UI.

Hi @alxbridge Please could you expand on the issue you have seen. It seems to be working OK for me locally.

Ah it works OK with initial data, e.g. not pulled data. But the export isn't visible with remote data pulled in. I'll look into it.

@nickmoreton
Copy link
Contributor Author

Issue: The customisation to the aging pages report (see AgingPagesReportView in rca/reports/views.py) appears to have stopped working - probably due to the shift to the Universal Listings UI.

Hi @alxbridge Please could you expand on the issue you have seen. It seems to be working OK for me locally.

Ah it works OK with initial data, e.g. not pulled data. But the export isn't visible with remote data pulled in. I'll look into it.

I was checking the wrong Report page (page types usage) the Aging pages report looks OK to me with pulled data.

@alxbridge
Copy link
Contributor

Issue: The customisation to the aging pages report (see AgingPagesReportView in rca/reports/views.py) appears to have stopped working - probably due to the shift to the Universal Listings UI.

Hi @alxbridge Please could you expand on the issue you have seen. It seems to be working OK for me locally.

Sorry for not being more specific to start with: the customised report adds a column for the page's URL which doesn't show up for me

@nickmoreton
Copy link
Contributor Author

Issue: The customisation to the aging pages report (see AgingPagesReportView in rca/reports/views.py) appears to have stopped working - probably due to the shift to the Universal Listings UI.

Hi @alxbridge Please could you expand on the issue you have seen. It seems to be working OK for me locally.

Sorry for not being more specific to start with: the customised report adds a column for the page's URL which doesn't show up for me

I think that column is only in the exported data, I can see it OK in an export on the master branch and the upgrade branch. I'm not seeing that column on either branch in the list view.

@alxbridge
Copy link
Contributor

I think that column is only in the exported data, I can see it OK in an export on the master branch and the upgrade branch. I'm not seeing that column on either branch in the list view.

I've just re-tested and it does actually get output as expected for the full report: the problem only seems to arise if you apply filters before the export.

@nickmoreton
Copy link
Contributor Author

I think that column is only in the exported data, I can see it OK in an export on the master branch and the upgrade branch. I'm not seeing that column on either branch in the list view.

I've just re-tested and it does actually get output as expected for the full report: the problem only seems to arise if you apply filters before the export.

I looked at this @alxbridge and you are correct. What I also discovered is if you refresh the page with the filter querystring in place it does work then. It's because the to_row_dict doesn't get called with filtering updates but does with page loading.

@nickmoreton
Copy link
Contributor Author

I think that column is only in the exported data, I can see it OK in an export on the master branch and the upgrade branch. I'm not seeing that column on either branch in the list view.

I've just re-tested and it does actually get output as expected for the full report: the problem only seems to arise if you apply filters before the export.

I looked at this @alxbridge and you are correct. What I also discovered is if you refresh the page with the filter querystring in place it does work then. It's because the to_row_dict doesn't get called with filtering updates but does with page loading.

Hi @alxbridge After a few wrong turns I finally fixed this. I wish there were more chages required but it was simple in the end 😄 1f6f8e9

Copy link
Contributor

@alxbridge alxbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest version all looks good - approved, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants