#7888 - BUG | Home 'Hero CTA sub text' #1050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickcuagan
commented
Sep 20, 2024
| @@ -1,6 +1,6 @@ | |||
| .hero-action-pane { | |||
| $root: &; | |||
| $hero-action-pane-height-small: 110px; | |||
| $hero-action-pane-height-small: 190px; | |||
There was a problem hiding this comment.
I explored options where we don't hard code this but think we're going to have to refactor quite a bit if we wanted to.
There was a problem hiding this comment.
Hey @patrickcuagan I think we should explore this further with RCA.
If we make this change and the content editors add to these fields is later reduced, we could end up with the component appearing too high up:
There was a problem hiding this comment.
Agreed to proceed with this, but we'll create a separate ticket for refactoring this component in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://torchbox.monday.com/boards/1472452416/pulses/1630887888
This PR fixes an issue where the hero CTA sub text is cut off on mobile.
Screenshot: